Draft
Conversation
The `Task` provides an interface for cancellation
They don't work well with coroutines + we already offer means to cleanly shutdown.
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
7e51fd6 to
5b0158d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
===========================================
- Coverage 100.00% 95.92% -4.08%
===========================================
Files 15 21 +6
Lines 787 712 -75
===========================================
- Hits 787 683 -104
- Misses 0 29 +29 ☔ View full report in Codecov by Sentry. |
# Conflicts: # poetry.lock # pyproject.toml # src/safeds_runner/server/_messages.py # src/safeds_runner/server/_pipeline_manager.py # tests/safeds_runner/server/test_websocket_mock.py
# Conflicts: # poetry.lock # pyproject.toml
# Conflicts: # poetry.lock # pyproject.toml # src/safeds_runner/server/_pipeline_manager.py # src/safeds_runner/server/_server.py # src/safeds_runner/server/messages/_from_server.py # tests/safeds_runner/server/test_server.py
Breaks when file gets formatted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Closes #90
Closes #92
Summary of Changes
save_placeholderwith two methods to either just report that a placeholder was computed and another to immediately send the value.progressmessage to send percentage of work done and an optional message. We can later use this to report, say, how many epochs are already done when training a neural network.Message client -> server:
run- run a pipelineshutdown- shutdown the serverMessages server -> client:
placeholder_value- send the value of a placeholderprogress- report that a placeholder was computedruntime_warning- report a warning while running the pipelineruntime_error- report an error while running the pipelinedone- finished running the pipelineTODOs
placeholder_valuemessagetableWindowsargument ofrunmessagecwdargument ofrunmessage