chore: design-tokens 자동 반영#27
Conversation
|
검증 완료. design-tokens → Picke-iOS 자동 PR 흐름 정상 동작 확인 후 close. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9158ce51d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // MARK: - Spacing | ||
| static let s0: CGFloat = 0 | ||
| static let s2: CGFloat = 2 | ||
| static let s2: CGFloat = 3 |
There was a problem hiding this comment.
Restore
s2 spacing token to 2pt
Changing s2 from 2 to 3 makes the token semantically inconsistent with the spacing scale (s0=0, s4=4, s8=8, ...), and any screen using .s2 will now render with 50% larger gaps than intended. Because this constant is shared across the design system, the regression propagates to all components relying on the 2pt spacing step.
Useful? React with 👍 / 👎.
자동 생성된 디자인 토큰 반영
Source:
SWYP-Find/design-tokens@0a7b9cadff587e4ffd35d11463e6b4647811dd01Trigger:
pushonmainWorkflow run: #5
Branch:
chore/design-tokens-sync-20260512-133923→develop두 단계 검증 통과
$type/ alias 정합성)Tools/TokenGenerator.swift실행 (실제 사용 Swift 코드 생성)변경된 파일
Projects/Shared/DesignSystem/Resources/Mode 1.tokens.jsonProjects/Shared/DesignSystem/Sources/Color/ShapeStyle+.swiftProjects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Radius+.swiftProjects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Spacing+.swiftProjects/Shared/DesignSystem/Sources/UI/Token/ComponentToken.swift