Skip to content

chore: design-tokens 자동 반영#27

Closed
Roy-wonji wants to merge 1 commit into
developfrom
chore/design-tokens-sync-20260512-133923
Closed

chore: design-tokens 자동 반영#27
Roy-wonji wants to merge 1 commit into
developfrom
chore/design-tokens-sync-20260512-133923

Conversation

@Roy-wonji
Copy link
Copy Markdown
Contributor

자동 생성된 디자인 토큰 반영

Source: SWYP-Find/design-tokens@0a7b9cadff587e4ffd35d11463e6b4647811dd01
Trigger: push on main
Workflow run: #5
Branch: chore/design-tokens-sync-20260512-133923develop

두 단계 검증 통과

  • 1차: Style Dictionary v4 빌드 (DTCG $type / alias 정합성)
  • 2차: Tools/TokenGenerator.swift 실행 (실제 사용 Swift 코드 생성)

변경된 파일

  • Projects/Shared/DesignSystem/Resources/Mode 1.tokens.json
  • Projects/Shared/DesignSystem/Sources/Color/ShapeStyle+.swift
  • Projects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Radius+.swift
  • Projects/Shared/DesignSystem/Sources/Extension/CGFloat/CGFloat+Spacing+.swift
  • Projects/Shared/DesignSystem/Sources/UI/Token/ComponentToken.swift

자동 생성된 PR. 토큰 변경 시마다 새 브랜치/새 PR 이 생성되며, 머지 시 브랜치는 자동 삭제됩니다.

@Roy-wonji
Copy link
Copy Markdown
Contributor Author

검증 완료. design-tokens → Picke-iOS 자동 PR 흐름 정상 동작 확인 후 close.

@Roy-wonji Roy-wonji closed this May 12, 2026
@Roy-wonji Roy-wonji deleted the chore/design-tokens-sync-20260512-133923 branch May 12, 2026 13:40
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9158ce51d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// MARK: - Spacing
static let s0: CGFloat = 0
static let s2: CGFloat = 2
static let s2: CGFloat = 3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore s2 spacing token to 2pt

Changing s2 from 2 to 3 makes the token semantically inconsistent with the spacing scale (s0=0, s4=4, s8=8, ...), and any screen using .s2 will now render with 50% larger gaps than intended. Because this constant is shared across the design system, the regression propagates to all components relying on the 2pt spacing step.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant