8주차 미션 [이서]#30
Open
seoyoon127 wants to merge 14 commits into
Open
Conversation
yangjiae12
approved these changes
May 22, 2026
| private final MemberRepository memberRepository; | ||
|
|
||
| @Transactional | ||
| public AuthResDto.Id signUp(AuthReqDto.Signup dto) { |
Member
There was a problem hiding this comment.
회원가입 시에 이메일 중복 검사를 추가하면 좋을 것 같습니다~
Comment on lines
+45
to
+46
| memberRepository.save(member); | ||
| member.updateFoodList(list); |
Member
There was a problem hiding this comment.
현재는 memberRepository.save(member) 이후 member.updateFoodList(list)를 호출하고 있는데, 음식 카테고리도 회원가입 과정에서 함께 생성되는 연관 정보이므로 먼저 연관관계를 세팅한 뒤 저장하는 흐름이 더 자연스러울 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항