fix: remove stale Vercel env var references - closes #2648#2649
Closed
github-actions[bot] wants to merge 1 commit into
Closed
fix: remove stale Vercel env var references - closes #2648#2649github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
- Remove NEXT_PUBLIC_VERCEL_GIT_COMMIT_REF fallback from get-tina-endpoint.tsx - Remove NEXT_PUBLIC_VERCEL_GIT_COMMIT_REF fallback from generate-archived-rules.js - Remove VERCEL_ENV=preview from .env.example - Update .env.example comment to reflect Azure-only hosting Note: The Vercel GitHub App integration also needs to be disconnected from the Vercel dashboard / GitHub repository settings to stop the failing Vercel build checks on PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Aibono1225
deleted the
fix/remove-stale-vercel-references-d061d7dd96a2e6d0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2648
SSW Rules is hosted on Azure (not Vercel). This PR removes stale Vercel references from the codebase.
Changes
utils/tina/get-tina-endpoint.tsx— removedNEXT_PUBLIC_VERCEL_GIT_COMMIT_REFfrom the branch detection fallback chain;NEXT_PUBLIC_TINA_BRANCHis set explicitly in Azure CI so this fallback was never neededscripts/generate-archived-rules.js— same cleanup for thegetBranch()helper.env.example— removedVERCEL_ENV=previewand updated the comment to reflect GitHub/Azure as the only CI platformsThe Vercel GitHub App integration is still connected to this repository and is the root cause of the failing build checks seen in PRs (e.g. #2646). This cannot be removed via a code change — a maintainer needs to:
ssw-rules→ Settings → Git → disconnect the GitHub integration, orOnce disconnected, the Vercel bot will stop commenting on PRs and the failing Vercel check will disappear.
Testing
NEXT_PUBLIC_TINA_BRANCHexplicitly (seebuild-and-deploy.ymlline 191), so removing the Vercel fallback has no runtime impact.VERCEL_ENVorNEXT_PUBLIC_VERCEL_GIT_COMMIT_REF.