Tests: Add integration tests validating SSSD socket#8481
Open
aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
Open
Tests: Add integration tests validating SSSD socket#8481aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new suite of integration tests for SSSD's socket activation feature. The tests validate the lifecycle of individual socket-activated responders and also cover scenarios with a mix of socket-activated and traditional services. The implementation is generally good, but I've identified a high-severity issue in one of the tests where a necessary service restart is missing after configuration changes. This could make the test unreliable. My review includes a specific suggestion to fix this.
aborah-sudo
force-pushed
the
socket
branch
3 times, most recently
from
e858e8c to
d5b5bb0
Compare
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.