Skip to content

PO: remove stray </arg> from translation#8413

Merged
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
alexey-tikhonov:es-po
Feb 3, 2026
Merged

PO: remove stray </arg> from translation#8413
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
alexey-tikhonov:es-po

Conversation

@alexey-tikhonov
Copy link
Member

No description provided.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Jan 29, 2026
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@alexey-tikhonov alexey-tikhonov linked an issue Jan 29, 2026 that may be closed by this pull request
@alexey-tikhonov
Copy link
Member Author

@joakim-tjernlund, could you please check if this resolves an issue with es/pam_sss.8.xml for you?

@joakim-tjernlund
Copy link

@joakim-tjernlund, could you please check if this resolves an issue with es/pam_sss.8.xml for you?

es/pam_sss.8.xml:34: parser error : Opening and ending tag mismatch: cmdsynopsis line 21 and arg
<replaceable>require_cert_auth</replaceable> </arg> </arg> <arg
                                                          ^
es/pam_sss.8.xml:35: parser error : Opening and ending tag mismatch: refsynopsisdiv line 20 and cmdsynopsis
ce='opt'> <replaceable>allow_chauthtok_by_root</replaceable> </arg></cmdsynopsis
                                                                               ^
es/pam_sss.8.xml:36: parser error : Opening and ending tag mismatch: refentry line 6 and refsynopsisdiv
    </refsynopsisdiv>
                     ^
es/pam_sss.8.xml:466: parser error : Opening and ending tag mismatch: reference line 4 and refentry
</refentry>
           ^
make[3]: *** [Makefile:985: es/pam_sss.8] Error 4
ls: cannot access 'pt_BR/*.xml': No such file or directory
ls: cannot access 'tr/*.xml': No such file or directory
uk/sss_ssh_knownhosts.1.xml:53: parser error : Premature end of data in tag refsect1 line 51
        
        ^

@joakim-tjernlund
Copy link

@joakim-tjernlund, could you please check if this resolves an issue with es/pam_sss.8.xml for you?

es/pam_sss.8.xml:34: parser error : Opening and ending tag mismatch: cmdsynopsis line 21 and arg
<replaceable>require_cert_auth</replaceable> </arg> </arg> <arg
                                                          ^
es/pam_sss.8.xml:35: parser error : Opening and ending tag mismatch: refsynopsisdiv line 20 and cmdsynopsis
ce='opt'> <replaceable>allow_chauthtok_by_root</replaceable> </arg></cmdsynopsis
                                                                               ^
es/pam_sss.8.xml:36: parser error : Opening and ending tag mismatch: refentry line 6 and refsynopsisdiv
    </refsynopsisdiv>
                     ^
es/pam_sss.8.xml:466: parser error : Opening and ending tag mismatch: reference line 4 and refentry
</refentry>
           ^
make[3]: *** [Makefile:985: es/pam_sss.8] Error 4
ls: cannot access 'pt_BR/*.xml': No such file or directory
ls: cannot access 'tr/*.xml': No such file or directory
uk/sss_ssh_knownhosts.1.xml:53: parser error : Premature end of data in tag refsect1 line 51
        
        ^

Needed to manually delete es/pam_sss.8.xml and then i got:

Making all in po
Making all in src/man
ls: cannot access 'pt_BR/*.xml': No such file or directory
ls: cannot access 'tr/*.xml': No such file or directory
uk/sss_ssh_knownhosts.1.xml:53: parser error : Premature end of data in tag refsect1 line 51
        
        ^
make[3]: *** [Makefile:973: uk/sss_ssh_knownhosts.1] Error 4

So it helpt but the uk/sss_ssh_knownhosts.1.xml:53 error is still there

@alexey-tikhonov
Copy link
Member Author

So it helpt but the uk/sss_ssh_knownhosts.1.xml:53 error is still there

I have no clue what's wrong with this one...

@joakim-tjernlund
Copy link

So it helpt but the uk/sss_ssh_knownhosts.1.xml:53 error is still there

I have no clue what's wrong with this one...

The odd thing is that on this particular machine there is an error but our main stream machines do not error here.
They are all Gentoo and up to date but one is a server and the other is Desktop but I think the build tools should be the same.
What tools are involved here? I can check if these are built differently.

@alexey-tikhonov
Copy link
Member Author

What tools are involved here?

xmllint, xsltproc, po4a... maybe something else.

@alexey-tikhonov
Copy link
Member Author

What tools are involved here?

xmllint, xsltproc, po4a... maybe something else.

Btw, it's reproducible on my machine in the sense it results in truncated man page translation. Yet I have no clue how to fix.

@alexey-tikhonov
Copy link
Member Author

@joakim-tjernlund, I added another patch that fixes 2nd issue on my machine.
Could you please test it?

@sumit-bose
Copy link
Contributor

Hi,

both patches fix the issues for me as well. Waiting for confirmation from Joakim before ACKing the patches.

Do you know how to fix this in Weblate to avoid regressions?

bye,
Sumit

@alexey-tikhonov
Copy link
Member Author

Do you know how to fix this in Weblate to avoid regressions?

IIUC, it should be enough to merge fix here and Weblate should update (and rebase open PR if any) automatically.
Sometimes it's stuck and requires manual intervention.

@alexey-tikhonov alexey-tikhonov added the Trivial A single reviewer is sufficient to review the Pull Request label Feb 3, 2026
@joakim-tjernlund
Copy link

Works for me

Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the fixes and the related research, ACK.

bye,
Sumit

Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
@sssd-bot
Copy link
Contributor

sssd-bot commented Feb 3, 2026

The pull request was accepted by @sumit-bose with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🔴 ci / system (fedora-44) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov alexey-tikhonov merged commit af5fbd5 into SSSD:master Feb 3, 2026
15 of 16 checks passed
@alexey-tikhonov
Copy link
Member Author

Do you know how to fix this in Weblate to avoid regressions?

IIUC, it should be enough to merge fix here and Weblate should update (and rebase open PR if any) automatically. Sometimes it's stuck and requires manual intervention.

Looks like #8361 was rebased correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sssd build error, git master

4 participants