Conversation
Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the project's dependencies to use a personal fork of sssd-test-framework. This introduces a critical security and maintainability risk by sourcing code from an unofficial repository. My review strongly advises against this change and recommends reverting to the official dependency to maintain the project's integrity.
| #git+https://github.com/SSSD/sssd-test-framework | ||
| git+https://github.com/madhuriupadhye/sssd-test-framework@dns_zone |
There was a problem hiding this comment.
This change replaces the official sssd-test-framework dependency with a version from a personal fork. Using dependencies from personal forks is a major security risk, as they can contain unvetted or malicious code, and are not guaranteed to be maintained. This also creates a maintenance burden, as the fork may diverge from the official project. Please revert to using the official dependency from the SSSD organization.
git+https://github.com/SSSD/sssd-test-framework
1 participant
No description provided.