design pages: Add completeUri to eidp example

[eisenmann-b1]

Includes a note about it being optional.

Also changes uri, to show that it generally does not include code.

[gemini-code-assist]

Summary of Changes

Hello @eisenmann-b1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the eidp example within the passwordless GDM design documentation. The primary goal is to provide a more accurate and comprehensive illustration of how completeUri and uri fields are used, along with clarifying the optional nature of completeUri, thereby enhancing the clarity and utility of the documentation for developers integrating with the system.

Highlights

• Example Update: Added a completeUri field to the eidp example in the passwordless GDM design page, demonstrating its usage with a login URL including a code.
• Documentation Clarification: Included a note explicitly stating that the completeUri field is optional and will be empty if not supported by the Identity Provider (IdP).
• URI Field Refinement: Modified the uri field in the example to show that it typically does not include the code parameter, differentiating it from completeUri.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/design-pages/passwordless_gdm.rst
  • Added completeUri field to the eidp JSON example.
  • Updated uri field in the eidp JSON example to remove the code parameter.
  • Inserted a note clarifying that completeUri is optional.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the passwordless_gdm.rst design document to include the completeUri field in the EIdP authentication example. This change also clarifies the uri field's content and adds a note explaining that completeUri is an optional field. My review includes a suggestion to rephrase this note for better clarity, to avoid ambiguity about what 'empty' means in the JSON payload.

[gemini-code-assist]

The term "empty" can be ambiguous in a JSON context. It could mean an empty string (""), null, or that the key is omitted entirely. To make the documentation clearer for implementers, it's better to be specific. Assuming the key is omitted when not supported, the suggested change makes this explicit.

Suggested change

	**Note**: `completeUri` is optional; it will be empty if not supported by the IdP.
	**Note**: `completeUri` is optional and will be omitted if not supported by the IdP.