Revert "Tests: gdm utils and topology updates for xidp"

[spoore1]

This reverts commit 9e4c3dd.

This commit was causing failures due to insufficient checks in topology controller code for GDM.

[gemini-code-assist]

Summary of Changes

Hello @spoore1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous commit that introduced failures in GDM due to insufficient checks in the topology controller. The changes remove the IPA domain enrollment and adjust the GDM topology configuration to resolve these issues.

Highlights

• Revert Commit: This PR reverts commit 9e4c3dd due to failures caused by insufficient checks in the topology controller code for GDM.
• Topology Configuration: The domains parameter was removed from the GDM topology configuration in sssd_test_framework/topology.py.
• GDM Topology Controller: The PR removes the IPA domain enrollment from the GDM topology controller in sssd_test_framework/topology_controllers.py.
• GDM Utility Assertion: The raise_on_error parameter was removed from the assert_text function in sssd_test_framework/utils/gdm.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sssd_test_framework/topology.py
  • Removed the domains parameter from the GDM topology configuration.
• sssd_test_framework/topology_controllers.py
  • Removed the IPA domain enrollment from the GDM topology controller.
• sssd_test_framework/utils/gdm.py
  • Removed the raise_on_error parameter from the assert_text function.

Activity

• spoore1 reverted commit 9e4c3dd due to failures in GDM.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous commit that was causing failures. The revert removes code related to GDM topology setup and client enrollment. The changes in sssd_test_framework/topology.py and sssd_test_framework/topology_controllers.py are straightforward removals. However, the change in sssd_test_framework/utils/gdm.py introduces an inconsistency in the assert_text function. By removing raise_on_error=False, the function's behavior changes to raise an exception on failure instead of returning False, which contradicts its type hint and makes the return statement misleading. I've added a comment with a suggestion to fix this.