fix nested cloning issue; add some installation of build essential and cmake; update readme

[badboy1606]

Fix install script issues

This PR fixes issues in install.sh:

• Removes nested repository cloning
• Prevents directory confusion during installation
• Fixes permission errors when modifying /etc/localtime
• Makes installer safe to run from repo root

Tested on Pop!_OS(24.04 LTS) .

[crisiumnih]

In clean Ubuntu install git is not installed
This script serves the purpose to install every requirement and then clone pixels
A better alternative will be to check if pixels is already cloned (mostly in home directory) if not then clone

If the repository is already cloned running make install is enough and there’s no need to run install.sh.
An alternative (and cleaner) approach would be to improve the Makefile to also install build tools (pkg-config, toolchain, make). That would give two clear paths:

1. install.sh -> fresh setup
2. make install -> dependency setup only

@5iri confirm

[5iri]

all good, your idea make sense @badboy1606, do it this way.

it also allows for people who have git clone'd it earlier to run make install or just make in the $PROJECT_ROOT and it should build tools accordingly.

so the process in which I am thinking is,

a person does wget to download install.sh and this shell script build the essential tools and then hands over to make install for Pixels specific installations.

does this makes sense? @crisiumnih

[badboy1606]

So I have updated the install.sh.
Now all the dependencies will be installed using the Makefile and not the install.sh script

can you please review @crisiumnih @5iri

[5iri]

why are you changing this comment? doesn't show any significance though?

[badboy1606]

ok i will do it as it is

[5iri]

either you reduce the loc or increase it for formatting? you have increased it here and reduced it on

   debian|wsl) sudo apt install -y make ;;

[badboy1606]

switched to the original makefile only and just added some installation of buiild essential and cmake

[5iri]

lgtm

[5iri]

@crisiumnih can you also check once?