Skip to content

fix: force benchmark job exit after upload#71

Merged
SPerekrestova merged 1 commit into
mainfrom
codex/benchmark-force-exit-after-upload
May 22, 2026
Merged

fix: force benchmark job exit after upload#71
SPerekrestova merged 1 commit into
mainfrom
codex/benchmark-force-exit-after-upload

Conversation

@SPerekrestova

Copy link
Copy Markdown
Owner

Summary

  • add a guarded benchmark CLI exit path controlled by BENCHMARK_FORCE_OS_EXIT
  • set the guard only on the Cloud Run benchmark job
  • add tests for default SystemExit behavior and forced Cloud Run exit behavior

Why

After upgrading huggingface-hub, the Cloud Run smoke uploaded all artifacts but the process stayed alive after HF/Xet upload completion. The explicit Cloud Run guard lets the standalone benchmark worker exit cleanly after all work and flushes are done.

Validation

  • rtk uv run python -m py_compile eval/run_benchmark.py
  • rtk uv run pytest tests/eval/test_run_benchmark.py tests/test_tier1_benchmark_workflow.py -q
  • rtk uv run pytest tests/eval tests/test_download_interaction_db.py tests/test_tier1_benchmark_workflow.py -q
  • rtk uv run pytest tests/ --ignore=tests/test_rxnorm_client.py -q
  • rtk git diff --check

Copy link
Copy Markdown
Owner Author

LGTM


Generated by Claude Code

@SPerekrestova SPerekrestova merged commit 42d79da into main May 22, 2026
5 checks passed
@SPerekrestova SPerekrestova deleted the codex/benchmark-force-exit-after-upload branch May 22, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant