Open
Conversation
Still needs Fieldbus.Config.EthernetIP CROWN implementation for get and set configs.
Fixed Configuration for Ethernet/IP and added features to check if IP and Gateway are valid before setting the configuration to prevent errors.
|
@golluroSICKAG why we not just accept this pull request because its far better than the current state of the applicaiton in the main branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.0.1
New features
Checking IP address and Gw address against Netmask to ensure configuration is valid when setting a static IP address.
Improvements
Configuration of E/IP network is now complete
Bugfix
...
Following tasks were checked