[sc-58664] Add temp logging when response is not 200#155
Open
dhanya-sgnl wants to merge 3 commits intomainfrom
Open
[sc-58664] Add temp logging when response is not 200#155dhanya-sgnl wants to merge 3 commits intomainfrom
dhanya-sgnl wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds temporary debugging logging to capture response bodies from Azure AD API calls when they return non-200 status codes. This is intended to help diagnose production issues related to OOM errors during Entra group entity ingestion.
- Adds structured logging for failed Azure AD API responses to aid in debugging production issues
- Logs both the status code and response body content when API calls fail
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| slog.Error( | ||
| "Failed to read error response body", | ||
| slog.String("endpoint", endpoint), | ||
| "error", readErr, |
There was a problem hiding this comment.
The logging call is inconsistent with structured logging patterns. Use slog.Any("error", readErr) instead of the bare string and value pair to maintain consistency with other slog attributes.
Suggested change
| "error", readErr, | |
| slog.Any("error", readErr), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Added temp debugging for AzureAD
sc-58664
API References
Pull request intention
Pull request checklist