Draft
Conversation
Register the sap.ux.appWizard.showOutputChannel VS Code command so it can be invoked from the inquirer-gui output-tab-link when a long error message is clamped. Also declare the command in the extension manifest. #37088
…d output channel command (#37088)
… VS Code webview Vuetify's theme engine dynamically injects CSS custom properties with priority into a style element at runtime. In a VS Code dark-theme webview these resolve to white, causing a visible flash when clicking an autocomplete/select dropdown. Fix: initialise Vuetify's light theme colours from VS Code's own CSS variables (--vscode-input-background, --vscode-dropdown-background, --vscode-editor-background), read from document.body where VS Code injects them. A MutationObserver on document.body's class attribute updates the colours live whenever the user changes the VS Code theme without needing to close and reopen the generator panel. Defensive CSS rules are also added to globalStyles.css and inline in index.html for belt-and-braces coverage.
…8-output-tab-link
…quirer-gui#37088 release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the
showOutputTabLinkfeature (from@sap-devx/inquirer-gui) into the App Wizardbackend and frontend so that clicking the output tab link in the generator opens the
App Wizard output channel.
Closes
tool-suite#37088Changes
packages/backend/src/extCommands.tssap.ux.appWizard.showOutputChannelthat callstoggleOutput()to reveal the App Wizard output channelpackages/frontend/src/youi/App.vue@show-output-tab-linkevent emitted byinquirer-gui'sFormcomponentexecuteCommandvia RPC to triggersap.ux.appWizard.showOutputChannelpackages/frontend/package.json@sap-devx/inquirer-guifrom3.4.6→3.5.0(update to actual version after release)packages/frontend/src/youi/QuestionList.vuesetTimeout(..., 0)withrequestAnimationFrame(...)for the Vuetifydropdown resize workaround (prevents a flash when clicking
v-autocompletein theVS Code webview)
Testing
lengthy message)
"View details in the output tab." link appears below it