docs: improve destinations README with full_url guidance and consistency fixes#159
Merged
Merged
Conversation
… fixes, and odata_gen vs odata_abap overview - Add odata_gen vs odata_abap comparison to Overview explaining mutual exclusivity and consumption models - Move odata_gen partial/full table before odata_abap paragraph for logical flow - Add Local Preview Support row to partial vs full table (full_url not supported) - Add Local Preview row to Key Differences table with explanation of path conflict - Add known issues note for SAP Fiori elements framework when using full_url (Flex model) - Add SAP Fiori Freestyle Apps as item 5 in When to Use full_url section - Fix odata_abap ordering to appear first in Overview bullets and WebIDEUsage table - Fix 11 H4 heading case violations to comply with Chicago title case - Fix placeholder alt text on northwind_destination.png - Fix Service Centre → Service Center for consistency with SAP product name - Fix Environment check → Environment Check (proper name) - Fix awkward "as shown in the following URL" → "as shown in the following example" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🔗 Link Check ResultsThe link checker has completed. This is an optional check and will not block the PR. If broken links were found, please review them at your convenience. Last updated: Run #228 at 2026-05-21T08:34:40Z |
- Add Table of Contents (8 major headings, 28 total) - Move Additional Resources section to before License per KM section ordering - Fix 2x "Service Centre" → "Service Center" for consistency - Fix "behaviour" → "behavior" (American English) - Fix 2x "V2/V4" → "V2 and V4" (no slash notation for term pairs) - Standardize Note callouts to blockquote style (> **Note**:) - Fix "environment check" → "Environment Check" (proper noun) - Expand 5 contractions in technical prose (You're, it's, don't, Here's) - Fix "a HTTP" → "an HTTP" and "a SAP BTP" → "an SAP BTP" (article agreement) - Fix "authentication is working" → "authentication works" - Define BAS acronym on first use (SAP Business Application Studio) - Remove em dashes as clause separators in list items (m4) - Replace "a number of" with "several" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
odata_genvsodata_abapcomparison to the Overview section explaining the two consumption models and why they are mutually exclusivefull_urldestinations (path doubling causes HTTP 404)full_url(Flex model does not work)full_urluse caseodata_abapto appear first consistently in Overview bullets,WebIDEUsagetable, and Key Differences tableService Centre→Service Center,Environment check→Environment Check, and awkward prose on line 441Test Plan
npm run lint:mdpasses with no errors onmisc/destinations/README.md🤖 Generated with Claude Code