Open
Conversation
Added checks for homebrew and metal. Started on the log reader logic with getting the application info, the emulator info, and the settings info.
GreemDev
previously requested changes
Feb 5, 2025
Author
|
Alright i'm pretty happy with the code is right now, we have everything we need ( Application Info, Ryujinx Info, Notes, etc... ). I think it's ready for the discord implementation ? I'm going to mark this PR as ready for review in case you want to merge it and then work on the discord logic outside of the PR |
Author
|
If you want me to add comments or summaries anywhere, just let me know, I'd be happy to. |
Author
|
I just thought about it but there might be some licensing issues since I used Ryuko as a reference but idk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the logic required to analyze ryujinx logs.
This PR will only contain the code to analyze the contents of the log, not HOW to get the contents of the log, or actually creating an embed (The last one is just because i don't want to deal with Discord.NET).
I would like to do all of these, but i am already struggling enough, so it will be up to @GreemDev do it (sorry).