feat(swa): add subject tag to notes and replies#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re:) when replying.Changes
Threading helpers (
swa/)threading.js—getSubject(event)returns the firstsubjecttag value (or'');adornReplySubject(subject)prependsRe:unless the subject already starts withre:(case-insensitive).threading.test.js— unit tests for both helpers (present/absent/first-of-many; empty/plain/already-prefixed).Compose & reply (
swa/)index.html— optional subject input (max 80 chars) in the compose panel.app.js— the post handler attaches asubjecttag when set (clearing the field after posting);onReplytakes the reply form's subject and attaches it. Mention#[n]offsets account for the leading subject tag so references stay correct.feedView.js— the reply form gains a subject input pre-filled with theRe:-adorned parent subject (editable/clearable), passed through toonReply.Display (
swa/)feedView.js—renderEventandrenderReplyshow a.event-subjectheader (via.textContent) above the content when a subject is present.style.css—.event-subjectstyling.Test plan
subjecttag and shows as a header.subjecttag is added.@<hex>mention; confirm the mention still resolves (correct tag index).Re: …, is editable/clearable, and the reply carries the edited subject.