feat(swa): move info button to sidebar foot with matching styling#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
SWA (
swa/)index.html— remove the info button from the header bar; add it as the last child of the sidebar as a.sidebar-btnwith a stroke SVG info icon matching the sibling buttons. Keepsid="info-btn",aria-label/title="About"; nodata-sectionso it is not a section switch.app.js— scope the section-navigation query to.sidebar-btn[data-section]so the info button is not wired as a section switcher (noactivestate, noshowSection).style.css— remove the now-unused.info-btnrules; add.sidebar-btn-foot { margin-top: auto }to pin the button to the bottom of the rail and a smallpadding-bottomon the sidebar.Test plan