Added support for requireFailure when multiple gestured are attached#57
Open
blakgeek wants to merge 5 commits intoRyanMullins:masterfrom
Open
Added support for requireFailure when multiple gestured are attached#57blakgeek wants to merge 5 commits intoRyanMullins:masterfrom
blakgeek wants to merge 5 commits intoRyanMullins:masterfrom
Conversation
added 3 commits
July 16, 2015 12:13
Author
|
Usage would be as follows. <div hm-tap="foo"
hm-doubletap="bar"
hm-require-failure"{tap: 'doubletap', 'doubletap': ['pan', 'zoom']}">
</div>This would cancel tap on doubletap. Since the pan and zoom gestures aren't registered they are ignored and a warning is logged to the console. The quotes around the key event name is optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing requireFailure implementation doesn't always work because each gesture is a separate directive and not guaranteed to have been added to hammer instance. I added a new directive with higher priority to ensure that runs after all gestures have been added.