slh-dsa: implement DigestSigner/Verifier#1075
Open
daxpedda wants to merge 2 commits intoRustCrypto:masterfrom
Open
slh-dsa: implement DigestSigner/Verifier#1075daxpedda wants to merge 2 commits intoRustCrypto:masterfrom
slh-dsa: implement DigestSigner/Verifier#1075daxpedda wants to merge 2 commits intoRustCrypto:masterfrom
Conversation
daxpedda
commented
Sep 15, 2025
| .chain_update(adrs.compressed()); | ||
| m.iter().for_each(|x| sha.update(x.as_slice())); | ||
| m.iter() | ||
| .for_each(|x| Update::update(&mut sha, x.as_slice())); |
Contributor
Author
There was a problem hiding this comment.
Hitting the same problem as usual. This time really unclear how to avoid it without loosing access to all the QoL methods of Digest.
daxpedda
commented
Sep 15, 2025
Comment on lines
+23
to
+26
| pub trait HashDigest { | ||
| /// The associated `Digest` type. | ||
| type Digest: Update; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I originally had type Digest on HashSuite directly, but that made it publicly not accessible.
So I introduced HashDigest just to make it publicly accessible if users ever need to access the type.
daxpedda
force-pushed
the
slh-dsa-digest-signer-verifier
branch
from
2b45717 to
c89b73c
Compare
Contributor
Author
|
@tarcieri, follow-up from RustCrypto/traits#2011. |
Member
|
@daxpedda can you rebase this? I tried to resolve the conflicts unsuccessfully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to RustCrypto/elliptic-curves#1423.