Skip to content

fix(int): resolve panic in unbounded_shr_vartime for zero shift#1213

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
fcasal:fix-panics-intshr
Feb 26, 2026
Merged

fix(int): resolve panic in unbounded_shr_vartime for zero shift#1213
tarcieri merged 1 commit intoRustCrypto:masterfrom
fcasal:fix-panics-intshr

Conversation

@fcasal
Copy link
Contributor

@fcasal fcasal commented Feb 26, 2026

Fixes #1212 by using unbounded_shl instead of shl.

Adds a few regression tests and a proptest.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.88%. Comparing base (236d679) to head (a97c1db).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
+ Coverage   87.86%   87.88%   +0.01%     
==========================================
  Files         184      184              
  Lines       21005    21028      +23     
==========================================
+ Hits        18457    18480      +23     
  Misses       2548     2548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri
Copy link
Member

cc @andrewwhitehead

@tarcieri tarcieri merged commit b135572 into RustCrypto:master Feb 26, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Int::unbounded_shr_vartime panics on shift == 0

2 participants