fix: use correct byte order in NonZero::from_le_byte_array#1211
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Feb 26, 2026
Merged
fix: use correct byte order in NonZero::from_le_byte_array#1211tarcieri merged 1 commit intoRustCrypto:masterfrom
NonZero::from_le_byte_array#1211tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 87.86% 87.88% +0.01%
==========================================
Files 184 184
Lines 21005 21010 +5
==========================================
+ Hits 18457 18465 +8
+ Misses 2548 2545 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tarcieri
approved these changes
Feb 24, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "little-endian" function was incorrectly calling
T::from_be_byte_arrayinstead ofT::from_le_byte_array.