Skip to content

feat(kbkdf): enable missing_docs lint#132

Merged
newpavlov merged 2 commits into
RustCrypto:masterfrom
TheBestTvarynka:feat/kbkdf-doc
May 30, 2025
Merged

feat(kbkdf): enable missing_docs lint#132
newpavlov merged 2 commits into
RustCrypto:masterfrom
TheBestTvarynka:feat/kbkdf-doc

Conversation

@TheBestTvarynka

@TheBestTvarynka TheBestTvarynka commented May 28, 2025

Copy link
Copy Markdown

Hi,
I enabled missing_docs lint for the kbkdf crate and fixed compiler warnings.

closes #129

@newpavlov

Copy link
Copy Markdown
Member

We don't need the rust_2018_idioms lint, since IIUC the lints are already enabled by default on the edition which we use.

@TheBestTvarynka

TheBestTvarynka commented May 28, 2025

Copy link
Copy Markdown
Author

We don't need the rust_2018_idioms lint, since IIUC the lints are already enabled by default on the edition which we use.

@newpavlov I already fixed it (force pushed). My fork was not updated, and I missed that it is enabled

@TheBestTvarynka TheBestTvarynka marked this pull request as ready for review May 28, 2025 18:52
Comment thread kbkdf/src/lib.rs Outdated
Co-authored-by: Artyom Pavlov <newpavlov@gmail.com>
@newpavlov

Copy link
Copy Markdown
Member

Thank you!

@newpavlov newpavlov merged commit 406af93 into RustCrypto:master May 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kbkdf: enable missing_docs lint

3 participants