Fix incorrect LocalInvocationIndex type #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalInvocationIndex is a scalar u32 builtin, not a UVec3 vector: https://docs.vulkan.org/refpages/latest/refpages/source/LocalInvocationIndex.html The tests incorrectly used UVec3 which was not caught by spirv-val.
This should be checked by spirv-opt but it is not catching it. Even if they fix the issue, it doesn't hurt to double check as this will never change.
LegNeato
changed the title
Firestar99
approved these changes
Jan 9, 2026
Member
There was a problem hiding this comment.
I've actually been incorrectly using local_invocation_index with a UVec3 cause I confused it with local_invocation_id: UVec3 for quite some time, and only noticed like last week or so cause I had a two dimensional workgroup. 😅
The difference for an 8x8 workgroup:
local_invocation_id: UVec3has a range of0..8, 0..8, 0local_invocation_index: u32has a range of0..64 = 0..(8*8)- from experimental results on all platforms I tested
local_invocation_index: UVec3seems to be equivalent toUVec3::new(local_invocation_index, 0, 0), but this could as well be UB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalInvocationIndex is a scalar u32 builtin, not a UVec3 vector:
https://docs.vulkan.org/refpages/latest/refpages/source/LocalInvocationIndex.html
The tests incorrectly used UVec3 which was not caught by spirv-val.