Skip to content

πŸ§‘β€πŸ’» Lint typescript#296

Merged
Friedinger merged 3 commits into
mainfrom
ci/lint-typescript
Jul 10, 2026
Merged

πŸ§‘β€πŸ’» Lint typescript#296
Friedinger merged 3 commits into
mainfrom
ci/lint-typescript

Conversation

@Friedinger

Copy link
Copy Markdown
Member

This pull request updates the linting and formatting scripts in the ecoscan_app/package.json file to include a TypeScript type check. This ensures that type errors are caught during both linting and automatic fixing.

Build and linting improvements:

  • Updated the lint and fix scripts to run tsc --noEmit in addition to Prettier and Expo lint, so TypeScript type errors are now checked as part of the linting process.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Expo app’s lint and fix scripts now run TypeScript typechecking, and tsconfig.json enables additional compiler diagnostics for safer and more consistent code validation.

Changes

TypeScript validation

Layer / File(s) Summary
TypeScript validation configuration
ecoscan_app/package.json, ecoscan_app/tsconfig.json
Lint and fix scripts now run tsc --noEmit, and additional strict compiler checks are enabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: ✨ Enhancement

Suggested reviewers: Sophie235

Poem

I’m a rabbit checking types with care,
No hidden errors left in there.
Lint and fixes hop in line,
Strict checks make the codebase shine.
Squeak, compile, and all is fine!

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Title check βœ… Passed The title is related to the change, but it is a bit generic and only mentions TypeScript linting.
Description check βœ… Passed The description accurately matches the script and TypeScript type-check changes in the pull request.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/lint-typescript

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the πŸ‘· CI/CD Changes related to continuous integration/deployment label Jul 10, 2026
@Friedinger Friedinger force-pushed the ci/lint-typescript branch from 0d57725 to 353e85f Compare July 10, 2026 17:18
@Friedinger Friedinger marked this pull request as ready for review July 10, 2026 19:04

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ecoscan_app/tsconfig.json (1)

10-10: πŸ“ Maintainability & Code Quality | πŸ”΅ Trivial | πŸ’€ Low value

noImplicitAny is redundant with strict: true.

strict: true (line 4) already enables noImplicitAny. This line can be removed for clarity, though it's harmless.

♻️ Remove redundant flag
     "noUnusedParameters": true,
-    "noImplicitAny": true,
     "noFallthroughCasesInSwitch": true,
πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ecoscan_app/tsconfig.json` at line 10, Remove the redundant "noImplicitAny":
true compiler option from the TypeScript configuration, since strict: true
already enables it.
πŸ€– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@ecoscan_app/tsconfig.json`:
- Line 10: Remove the redundant "noImplicitAny": true compiler option from the
TypeScript configuration, since strict: true already enables it.

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 604c179a-9483-46fd-a237-dd130fe1d354

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 916787e and 38abbb1.

πŸ“’ Files selected for processing (2)
  • ecoscan_app/package.json
  • ecoscan_app/tsconfig.json

@IamPekka058 IamPekka058 self-requested a review July 10, 2026 19:07
@Friedinger Friedinger merged commit 80656a7 into main Jul 10, 2026
10 checks passed
@Friedinger Friedinger deleted the ci/lint-typescript branch July 10, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ‘· CI/CD Changes related to continuous integration/deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants