π§βπ» Lint typescript#296
Conversation
WalkthroughThe Expo appβs lint and fix scripts now run TypeScript typechecking, and ChangesTypeScript validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0d57725 to
353e85f
Compare
There was a problem hiding this comment.
π§Ή Nitpick comments (1)
ecoscan_app/tsconfig.json (1)
10-10: π Maintainability & Code Quality | π΅ Trivial | π€ Low value
noImplicitAnyis redundant withstrict: true.
strict: true(line 4) already enablesnoImplicitAny. This line can be removed for clarity, though it's harmless.β»οΈ Remove redundant flag
"noUnusedParameters": true, - "noImplicitAny": true, "noFallthroughCasesInSwitch": true,π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ecoscan_app/tsconfig.json` at line 10, Remove the redundant "noImplicitAny": true compiler option from the TypeScript configuration, since strict: true already enables it.
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ecoscan_app/tsconfig.json`:
- Line 10: Remove the redundant "noImplicitAny": true compiler option from the
TypeScript configuration, since strict: true already enables it.
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 604c179a-9483-46fd-a237-dd130fe1d354
π Files selected for processing (2)
ecoscan_app/package.jsonecoscan_app/tsconfig.json
This pull request updates the linting and formatting scripts in the
ecoscan_app/package.jsonfile to include a TypeScript type check. This ensures that type errors are caught during both linting and automatic fixing.Build and linting improvements:
lintandfixscripts to runtsc --noEmitin addition to Prettier and Expo lint, so TypeScript type errors are now checked as part of the linting process.