DAO-2231: Add Redeem Shares action to BTC Vault page#2108
Merged
Freshenext merged 3 commits intomainfrom Apr 16, 2026
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
TravellerOnTheRun
changed the base branch from
main
to
dao-2230-claim-shares-part-2
Freshenext
force-pushed
the
dao-2230-claim-shares-part-2
branch
from
6bf2eca to
839bc74
Compare
DAO-2231 Phases 1-4. - Add hasVaultShares to ActionEligibility from mapper snapshot - useBtcVaultWithdrawFlow for modal, allowance, redeem; backend delay on success - Dashboard wires eligibility + flow once; Actions take withdraw props - Redeem Shares under Wallet; loading gate; sync busy state with actions row
DAO-2231 Phase 3. - Spy refetchActiveRequests from useActiveRequests mock - BtcVaultDashboard mock records props; expect onRequestSubmitted and onAfterClaimRefetch to match refetch - Add hasVaultShares to ActionEligibility mocks for consistency
Wire dashboard Redeem Shares to claimableRedeemNative via useClaimRequest and btcVaultClaim, matching transaction history and detail claim flow. Expose claimableWithdrawRequest from useActiveRequests; keep new withdraw requests on the Withdraw action.
TravellerOnTheRun
force-pushed
the
dao-2231
branch
from
48a4749 to
9945c9b
Compare
cybervoid0
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
BTC Vault users who hold vault shares can already start a withdrawal (redeem) from the actions area at the bottom of the page. Product asked for the same capability in context: a Redeem Shares control next to Wallet in MY METRICS, so people see the action where they scan balances, not only when they scroll to the bottom.
This PR adds that CTA and wires it to the same redeem path as the existing Withdraw control (modal, allowance, contract action, refetch), so behavior and edge cases stay aligned.
What problem it solves
Behavior (acceptance criteria, plain language)
Design / UX notes
Dependency note
This work is intended to sit on top of the BTC Vault claim shares dashboard layout (DAO-2230): same MY METRICS row structure (metric column + CTA below). If you are reviewing from
mainbefore 2230 lands, rebase or merge order may affect the dashboard diff.How to review (suggested)
BalanceInfothen Redeem Shares; compare to Vault shares + Claim column.hasVaultSharesis derived with the same multicall-backed eligibility as other vault actions, avoiding a second “balance” source for visibility.