DAO-1983 (C6/6): Final batch + remove legacy block-time constants#2097
Open
TravellerOnTheRun wants to merge 1 commit intodao-1983-c5from
Open
DAO-1983 (C6/6): Final batch + remove legacy block-time constants#2097TravellerOnTheRun wants to merge 1 commit intodao-1983-c5from
TravellerOnTheRun wants to merge 1 commit intodao-1983-c5from
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
TravellerOnTheRun
force-pushed
the
dao-1983-c6
branch
from
a681853 to
9dc49dc
Compare
TravellerOnTheRun
force-pushed
the
dao-1983-c5
branch
from
71044a9 to
2e3c339
Compare
… (DAO-1983 C6/6) Drop AVERAGE_BLOCKTIME and DEFAULT_NUMBER_OF_SECONDS_PER_BLOCK; Countdown uses useBlockTime. Completes call-site migration.
TravellerOnTheRun
force-pushed
the
dao-1983-c6
branch
from
9dc49dc to
1fa8e79
Compare
sleyter93
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The last readers (including BTC vault) and fund-manager hooks are moved off
AVERAGE_BLOCKTIME. This PR also removes the legacy exports fromconstantsand updates Countdown to useuseBlockTime()so “blocks × seconds” uses the same average the rest of the app trusts.Until this lands, the old constant must remain for any file not yet migrated—this PR finishes that migration for the DAO-1983 scope.
What to check
AVERAGE_BLOCKTIME/ removed seconds-per-block constant in this workstream.Stack
Final slice of Strategy C—merge after C5.