Potential fix for code scanning alert no. 10: Information exposure through an exception#17
Merged
Rootless-Ghost merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/SigmaForge/security/code-scanning/10
To fix the problem, the exception details should be logged server-side and replaced with a generic error message in the HTTP response. This prevents potential exposure of internal file paths, rule-directory layouts, or other environment details to an external caller, while retaining sufficient information in logs for debugging.
Concretely, in
app.pywithinapi_list_rules, replace theexceptblock that directly returnsstr(e)with one that useslogging.exceptionto log the full traceback and returns a generic error message similar to the other API endpoints (api_validate,api_convert,api_save_rule, etc.). No behavioral change is introduced for successful requests; only the error payload content is made less specific. The file already importsloggingat the top, so no new imports are needed. Only theexceptblock at lines 251–252 needs to be edited.Suggested fixes powered by Copilot Autofix. Review carefully before merging.