Skip to content

fix: allow markdown tables to scroll horizontally instead of compressing #12027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-v0 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: allow markdown tables to scroll horizontally instead of compressing #12027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions webview-ui/src/components/common/MarkdownBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,8 @@ const StyledMarkdown = styled.div`
/* Table styles for remark-gfm */
table {
border-collapse: collapse;
margin: 1em 0;
width: auto;
min-width: 50%;
max-width: 100%;
table-layout: fixed;
}

/* Table wrapper for horizontal scrolling */
Expand All @@ -184,8 +181,7 @@ const StyledMarkdown = styled.div`
border: 1px solid var(--vscode-panel-border);
padding: 8px 12px;
text-align: left;
word-wrap: break-word;
overflow-wrap: break-word;
white-space: nowrap;
}

th {
Expand Down
22 changes: 22 additions & 0 deletions webview-ui/src/components/common/__tests__/MarkdownBlock.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,28 @@ describe("MarkdownBlock", () => {
expect(screen.getByText("Step three")).toBeInTheDocument()
})

it("should render tables inside a scrollable wrapper", async () => {
const markdown = `| Column A | Column B | Column C |
| --- | --- | --- |
| Data 1 | Data 2 | Data 3 |`

const { container } = render(<MarkdownBlock markdown={markdown} />)

await screen.findByText("Column A")

// Table should be wrapped in a .table-wrapper div for horizontal scrolling
const wrapper = container.querySelector(".table-wrapper")
expect(wrapper).toBeInTheDocument()

const table = wrapper?.querySelector("table")
expect(table).toBeInTheDocument()

// Verify table content renders correctly
expect(screen.getByText("Column B")).toBeInTheDocument()
expect(screen.getByText("Data 1")).toBeInTheDocument()
expect(screen.getByText("Data 3")).toBeInTheDocument()
})

it("should render nested lists with proper hierarchy", async () => {
const markdown = `Complex list:
1. First level ordered
Expand Down
Loading