Skip to content

feat(i18n): add Hebrew (he) locale support#12021

Draft
roomote-v0[bot] wants to merge 3 commits intomainfrom
feature/add-hebrew-locale
Draft

feat(i18n): add Hebrew (he) locale support#12021
roomote-v0[bot] wants to merge 3 commits intomainfrom
feature/add-hebrew-locale

Conversation

@roomote-v0
Copy link
Copy Markdown
Contributor

@roomote-v0 roomote-v0 bot commented Mar 27, 2026

Related GitHub Issue

Closes: #12020

Description

This PR attempts to address Issue #12020 by adding Hebrew (he) locale support to Roo Code. Feedback and guidance are welcome.

Changes made:

  1. Registered "he" in the Language type (packages/types/src/vscode.ts) - added in alphabetical order between "fr" and "hi"
  2. Added Hebrew to the language name mapping (src/shared/language.ts) - added he: "עברית"
  3. Created backend translation files (src/i18n/locales/he/) - copied from English templates: common.json, embeddings.json, marketplace.json, mcp.json, skills.json, tools.json, worktrees.json
  4. Created webview-ui translation files (webview-ui/src/i18n/locales/he/) - copied from English templates: chat.json, cloud.json, common.json, history.json, marketplace.json, mcp.json, prompts.json, settings.json, welcome.json, worktrees.json, plus .gitkeep

What is NOT needed (auto-discovered at runtime):

  • Both src/i18n/setup.ts and webview-ui/src/i18n/setup.ts dynamically discover locale directories, so no setup file changes are required.

Regarding RTL support:

  • The i18n infrastructure (i18next) supports RTL languages, but adding full RTL CSS/layout support across all components is a larger effort that warrants a separate issue. This PR focuses on adding the locale scaffolding so Hebrew can be selected and strings can be translated.

Test Procedure

  • Ran node scripts/find-missing-translations.js - all locales pass with no missing translations
  • Ran cd src && npx vitest run shared/__tests__/language.spec.ts - all 3 tests pass
  • Lint and type-check pass via pre-push hooks (turbo lint + turbo check-types)

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.

Additional Notes

The Hebrew translation files currently contain English strings as starting templates. These can be incrementally translated by Hebrew-speaking contributors.

Interactively review PR in Roo Code Cloud

@lidorshimoni
Copy link
Copy Markdown

@roomote, please translate all the English template strings to Hebrew, and then I'll review and fix them manually where it's needed.

@roomote-v0
Copy link
Copy Markdown
Contributor Author

roomote-v0 bot commented Mar 27, 2026

Fixaroo Clock   See task

Translated all 17 Hebrew locale files from English to Hebrew (7 backend + 10 webview-ui). All translation validation checks pass.

View commit | Revert commit

roomote added 2 commits March 27, 2026 21:00
…brew

Translates all 17 Hebrew locale files (7 backend + 10 webview-ui)
from English template strings to proper Hebrew translations.

Backend files:
- src/i18n/locales/he/common.json
- src/i18n/locales/he/embeddings.json
- src/i18n/locales/he/marketplace.json
- src/i18n/locales/he/mcp.json
- src/i18n/locales/he/skills.json
- src/i18n/locales/he/tools.json
- src/i18n/locales/he/worktrees.json

WebView UI files:
- webview-ui/src/i18n/locales/he/chat.json
- webview-ui/src/i18n/locales/he/cloud.json
- webview-ui/src/i18n/locales/he/common.json
- webview-ui/src/i18n/locales/he/history.json
- webview-ui/src/i18n/locales/he/marketplace.json
- webview-ui/src/i18n/locales/he/mcp.json
- webview-ui/src/i18n/locales/he/prompts.json
- webview-ui/src/i18n/locales/he/settings.json
- webview-ui/src/i18n/locales/he/welcome.json
- webview-ui/src/i18n/locales/he/worktrees.json

All placeholders ({{variable}}) preserved exactly as in English source.
Technical terms and brand names kept in English where appropriate.
Validation script confirms no missing translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add Hebrew (he) locale support

2 participants