fix: clarify folded file context blocks during condensation#12000
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
fix: clarify folded file context blocks during condensation#12000roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
…sation Models were misinterpreting condensed file summaries as "compressed" read_file output, causing them to repeatedly fetch small snippets. This adds a clear note to each <system-reminder> block explaining that it is a structural summary from context condensation (signatures only) and that read_file should be used to get full content when needed. Closes #11989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11989
Description
This PR attempts to address Issue #11989 where models misinterpret condensed file summaries as "compressed"
read_fileoutput, causing them to repeatedly fetch small snippets instead of reading full files.The fix adds a brief explanatory note to each
<system-reminder>block generated during context condensation:This note appears between the
## File Context:header and the tree-sitter definitions, making it clear to the model that:read_filetoolread_fileto get full content when implementation details are neededFiles changed:
src/core/condense/foldedFileContext.ts- Added explanatory note to both normal and truncated section templatessrc/core/condense/__tests__/foldedFileContext.spec.ts- Added test verifying the explanatory note is present and correctly positioned; adjusted budget test thresholdTest Procedure
cd src && npx vitest run core/condense/__tests__/)Pre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome.
Interactively review PR in Roo Code Cloud