Skip to content

Cut Controller Patterns Skill to under 200 Lines#27

Open
OutlawAndy wants to merge 2 commits into
mainfrom
culled-controller-skill
Open

Cut Controller Patterns Skill to under 200 Lines#27
OutlawAndy wants to merge 2 commits into
mainfrom
culled-controller-skill

Conversation

@OutlawAndy

Copy link
Copy Markdown
Member

I think the general guidance is for these things to be less than 200 lines.

My current thinking is most of our skills have far too much detail.

I also want to make a distinction between:

  1. workflow skills as we've started to build (and add to this repository)
  2. Pattern documentation skills (like this one)

Speaking only in regards to no. 2 (pattern docs), I think only the most generally applicable information should be included in this repository. Individual projects can always (and probably should) extend these with more specific guidelines.

If that doesn't line up with what others thing, than I'd like us to discuss our differing opinions so that I can revise mine if it's wrong..

For now, starting with this skill, because it seems the most straight forward in my mind..

Feedback is appreciated! Especially regarding the best place for text explanations - comments in example code vs. structured lists, for example.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR condenses the Rails controller pattern skill into a shorter pattern-documentation guide focused on generally applicable controller structure and conventions.

Changes:

  • Removes extensive decision trees, advanced examples, and detailed agent instructions.
  • Replaces them with compact standard and child-resource controller examples.
  • Keeps concise guidance for authorization, before actions, strong parameters, and flash messages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/controller-patterns/SKILL.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 03:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread skills/controller-patterns/SKILL.md
Comment thread skills/controller-patterns/SKILL.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants