Cut Controller Patterns Skill to under 200 Lines#27
Open
OutlawAndy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR condenses the Rails controller pattern skill into a shorter pattern-documentation guide focused on generally applicable controller structure and conventions.
Changes:
- Removes extensive decision trees, advanced examples, and detailed agent instructions.
- Replaces them with compact standard and child-resource controller examples.
- Keeps concise guidance for authorization, before actions, strong parameters, and flash messages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the general guidance is for these things to be less than 200 lines.
My current thinking is most of our skills have far too much detail.
I also want to make a distinction between:
Speaking only in regards to no. 2 (pattern docs), I think only the most generally applicable information should be included in this repository. Individual projects can always (and probably should) extend these with more specific guidelines.
If that doesn't line up with what others thing, than I'd like us to discuss our differing opinions so that I can revise mine if it's wrong..
For now, starting with this skill, because it seems the most straight forward in my mind..
Feedback is appreciated! Especially regarding the best place for text explanations - comments in example code vs. structured lists, for example.