-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[NO MERGE] Build 4.68.1 #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO MERGE] Build 4.68.1 #6887
Conversation
WalkthroughVersion number decremented from 4.69.0 to 4.68.1 across Android build configuration, iOS project settings, iOS application plists, and package.json. Pure version string updates with no functional logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @package.json:
- Line 3: The commit incorrectly downgrades the package "version" field in
package.json from 4.69.0 to 4.68.1; revert the version change so the version key
in package.json is restored to the correct develop value (e.g., "4.69.0") or, if
these changes must go into develop with a new patch, bump it forward (e.g.,
"4.69.1"); alternatively, do not merge this branch into develop—target a
release/4.68.x branch or cherry-pick only the needed fixes—ensure the
package.json "version" entry is consistent with your chosen strategy before
merging.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
android/app/build.gradleios/RocketChatRN.xcodeproj/project.pbxprojios/RocketChatRN/Info.plistios/ShareRocketChatRN/Info.plistpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ESLint and Test / run-eslint-and-test
- GitHub Check: format
| { | ||
| "name": "rocket-chat-reactnative", | ||
| "version": "4.69.0", | ||
| "version": "4.68.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Version downgrade detected – do not merge to develop.
The version has been decremented from 4.69.0 to 4.68.1. Merging this to the develop branch would revert the version, breaking semantic versioning and potentially causing conflicts with published packages, CI/CD pipelines, and release workflows.
The PR title "[NO MERGE]" confirms this branch should not be merged. If this is a hotfix branch for version 4.68.1, consider:
- Merging to a release/4.68.x branch instead of develop
- Cherry-picking specific fixes rather than merging the entire branch
- Incrementing the version forward (e.g., 4.69.1) if changes need to go to develop
🤖 Prompt for AI Agents
In @package.json at line 3, The commit incorrectly downgrades the package
"version" field in package.json from 4.69.0 to 4.68.1; revert the version change
so the version key in package.json is restored to the correct develop value
(e.g., "4.69.0") or, if these changes must go into develop with a new patch,
bump it forward (e.g., "4.69.1"); alternatively, do not merge this branch into
develop—target a release/4.68.x branch or cherry-pick only the needed
fixes—ensure the package.json "version" entry is consistent with your chosen
strategy before merging.
|
Android Build Available Rocket.Chat 4.68.1.107984 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTilYwE6o6SfTkxTiC3d784gRSBij_koIBdYTXF4B4CAOTiupf5ab6F-AV9YfM8c587wOC_upWDnoW7WTSL |
|
Android Build Available Rocket.Chat Experimental 4.68.1.107983 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRKb2UO3p2t6WCnq8_oOFFVZk4P4DGAKdrmV2hL6omsQ2lk2RJ1qnkRJv7jGnmYtl0EGmjz2AHE94xi4eJo |
|
Android Build Available Rocket.Chat 4.68.1.107984 |
|
iOS Build Available Rocket.Chat 4.68.1.107985 |
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.