Fix Windows compatibility issue by replacing rm with rimraf#178
Open
ShubhamS2005 wants to merge 1 commit intoRocketChat:masterfrom
Open
Fix Windows compatibility issue by replacing rm with rimraf#178ShubhamS2005 wants to merge 1 commit intoRocketChat:masterfrom
ShubhamS2005 wants to merge 1 commit intoRocketChat:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
I tried running the CLI on Windows and encountered the error:
'rm' is not recognized as an internal or external command
This occurs because some scripts in
package.jsonuse the Unixrmcommand,which is not available on Windows environments.
To make the scripts cross-platform, I replaced
rmwithrimraf,which works consistently on Windows, macOS, and Linux.
Changes made:
rm -rf libwithrimraf librm -f oclif.manifest.jsonwithrimraf oclif.manifest.jsonTested locally on:
Code Change
Before:
"clean": "rm -rf lib",
"postpack": "rm -f oclif.manifest.json"
After:
"clean": "rimraf lib",
"postpack": "rimraf oclif.manifest.json"
Before
After
After this change,
npm installand the CLI setup run successfully without the Windows error.