Enhance AuthResponse model with token expiry and refresh parameters #25
Conversation
…hold This commit enhances the `AuthResponse` model by adding two new fields: `expires_in`, which indicates the token expiry time in seconds, and `refresh_threshold`, which suggests a recommended refresh time before the token expires. Additionally, the `_parse_response` function in `execute_cypher_query.py` has been cleaned up by removing outdated NDJSON handling code, improving overall response parsing efficiency. Testing Notes: - Verify that the new fields in `AuthResponse` are correctly serialized and deserialized. - Ensure that the `_parse_response` function behaves as expected with various response formats.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if response.status_code == 200: | ||
| content_type = response.headers.get("content-type", "") | ||
| if ( | ||
| "application/x-ndjson" in content_type | ||
| or response.headers.get("x-stream-format") == "ndjson" | ||
| ): | ||
| return None | ||
| response_200 = response.json() | ||
| return response_200 |
There was a problem hiding this comment.
The 200-response branch unconditionally calls response.json(), but NDJSON streaming endpoints return line-delimited JSON rather than a single JSON document. This call now raises JSONDecodeError or buffers the stream, preventing QueryClient.execute_query from detecting the NDJSON path (it expects parsed to be None when streaming). The previous logic explicitly returned None for NDJSON content types, so this change breaks streaming queries that rely on NDJSON.
Useful? React with 👍 / 👎.
This commit updates the `_parse_response` function in `execute_cypher_query.py` to return `None` for NDJSON responses, improving the robustness of response parsing. This change ensures that the function correctly identifies NDJSON content types and avoids unnecessary parsing attempts. Testing Notes: - Verify that NDJSON responses are handled correctly without errors. - Ensure that other response types continue to be processed as expected.
Summary
This PR refactors the
AuthResponsemodel to include additional token management parameters, specifically token expiry information and refresh threshold settings. The changes improve token lifecycle management capabilities within the robosystems client.Key Changes
Key Accomplishments
Breaking Changes
AuthResponsemodel structure has been modified. Existing code that directly instantiates or serializesAuthResponseobjects may need updates to accommodate the new fields.Testing Notes
Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
chore/auth-response-paramsmainCo-Authored-By: Claude noreply@anthropic.com