Type specification edits#168
Merged
RobertDober merged 27 commits intoRobertDober:masterfrom Mar 21, 2025
Merged
Conversation
…es are incidental whitespace formatting
… annotation be a regex
… EarmarkParser.Line
…rmarkParser.Parser.ListInfo
…ormalize_annotations/1`
lib/earmark_parser/parser/list_info.ex:29:21:unknown_type Unknown type: EarmarkParser.Line.ListItem.t/0. lib/earmark_parser/options.ex:55:37:unknown_type Unknown type: Message.t/0.
…ype: it's a list not a MapSet; change type container_type to container
…into type_specs
RobertDober
requested changes
Mar 19, 2025
…02669145 Replaced binary() with String,t()
…02682723 Added natural type
…02789798 _t isn't idiomatic; I'm going to guess someone has spent a lot of time in C :)
RobertDober
pushed a commit
that referenced
this pull request
Mar 24, 2025
- Fix rendering of multiple images with reflinks - Type specification edits (#168)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the exception of [one code refactor] (85d7c1e), these commits are the addition or correction of type specifications.
I tried to keep the commits very narrow in scope so you can pick and choose which edits are wanted.
Passed
mix testPassed
mix dialyzer