Consolidate Block modules into a single file, block.ex#167
Merged
RobertDober merged 6 commits intoRobertDober:masterfrom Mar 18, 2025
Merged
Consolidate Block modules into a single file, block.ex#167RobertDober merged 6 commits intoRobertDober:masterfrom
RobertDober merged 6 commits intoRobertDober:masterfrom
Conversation
…es are incidental whitespace formatting
Collaborator
Author
|
mix test worked for me: 50 doctests, 1005 tests, 0 failures, 5 excluded, 1 skipped |
RobertDober
added a commit
that referenced
this pull request
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the block-related modules by consolidating them into a single file (
block.ex) and introduces type definitions forEarmarkParser.Block.tandEarmarkParser.Link.t. The goal is to improve code organization, maintainability, and type safety.Related Issue: #166
Changes:
Removed the
blockfolder and all associated module files.Created
lib/earmark_parser/block.exto house the consolidated module.Consolidated all child modules into a single file.
Added type definition for
EarmarkParser.Block.t.Added type definition for
EarmarkParser.Link.t.Benefits: