Open
Conversation
/boot/uboot is not a mounted filesystem for all images and combinations. umount will fail if it's not, resulting in premature interruption of the flasher script.
Filesystems mount on subdirectories of /tmp are already unmounted earlier in the script. /tmp itself is not a mount point in all systems, and if it isn't, umount will fail when called to unmount it, resulting in premature termination of the flasher script. Also, it doesn't seem necessary to unmount /tmp in this script (which doesn't run as init) even if it is a mounted filesystem.
The -f flag causes the orderly shutdown (via shutdown -h) to be circumvented, which arguably isn't better for the board than doing an orderly shutdown, and can also easily result in the LEDs being in some odd state rather than signaling power off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some directories that the script tries to unmount aren't mounted, and as a result the script fails prematurely before finishing the eMMC flash.
As a result, using the script to flash the eMMC when booted with the latest image fails. The changes here are the ones needed to make that succeed.