fix: new agents default to configured model instead of hardcoded groq#968
Open
chrisyoung2005 wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix: new agents default to configured model instead of hardcoded groq#968chrisyoung2005 wants to merge 1 commit intoRightNow-AI:mainfrom
chrisyoung2005 wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Built-in templates and the spawn wizard both hardcoded provider = "groq" / model = "llama-3.3-70b-versatile" in the manifest TOML sent to the API. The kernel's default_model overlay only activates when provider/model are empty or "default", so hardcoded values bypassed the user's configured default entirely. Fixes RightNow-AI#967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The kernel's `default_model` overlay in `spawn_agent_with_parent` only activates when `provider`/`model` are empty or `"default"`. Hardcoded values bypassed the user's configured default entirely, causing new agents to boot with Groq regardless of what the user had set.
Changes
The backend kernel logic is correct and unchanged — it already handles `"default"` properly, including auto-detection when no provider is explicitly configured.
Testing
Security
Fixes #967