feat(channels): use plain text as default output formatter for Signal#1020
Open
rozsival wants to merge 4 commits intoRightNow-AI:mainfrom
Open
feat(channels): use plain text as default output formatter for Signal#1020rozsival wants to merge 4 commits intoRightNow-AI:mainfrom
rozsival wants to merge 4 commits intoRightNow-AI:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates channel output formatting defaults so Signal uses plain text by default (since Signal does not support Markdown), and applies rustfmt/clippy-driven cleanups across the workspace.
Changes:
- Set Signal’s default output format to
PlainTextin the channel bridge. - Apply
cargo fmt-style formatting updates across several crates. - Address a clippy warning in SSRF-related tests (
== false→!...).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/openfang-runtime/src/web_search.rs | Rustfmt formatting for SearxNG request URL construction. |
| crates/openfang-runtime/src/web_fetch.rs | Test formatting + clippy cleanup in SSRF/allowlist tests. |
| crates/openfang-runtime/src/tool_runner.rs | Rustfmt formatting around exec policy allowlist validation. |
| crates/openfang-runtime/src/session_repair.rs | Rustfmt formatting in test predicate match arm. |
| crates/openfang-runtime/src/mcp.rs | Rustfmt formatting for transport config builder usage. |
| crates/openfang-kernel/src/kernel.rs | Rustfmt formatting for constants and manifest comparison expression. |
| crates/openfang-hands/src/registry.rs | Rustfmt formatting in a unit test (single-line binding). |
| crates/openfang-cli/src/tui/screens/hands.rs | Rustfmt formatting for HandsAction::ActivateHand construction. |
| crates/openfang-channels/src/discord.rs | Rustfmt formatting in a JSON equality assertion test. |
| crates/openfang-channels/src/bridge.rs | Behavior change: default output format for signal set to PlainText. |
| crates/openfang-api/tests/api_integration_test.rs | Rustfmt formatting in an integration test assertion. |
| crates/openfang-api/src/routes.rs | Rustfmt formatting in message filtering logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Till this day, Signal does not support Markdown formatting. For that reason, it makes better sense to default its output formatter to
PlainText.Resources:
Changes
signalchannel set toPlainTextcargo fmtclippywarning inopenfang-runtimeTesting
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity