Skip to content

feat(channels): use plain text as default output formatter for Signal#1020

Open
rozsival wants to merge 4 commits intoRightNow-AI:mainfrom
rozsival:upstream
Open

feat(channels): use plain text as default output formatter for Signal#1020
rozsival wants to merge 4 commits intoRightNow-AI:mainfrom
rozsival:upstream

Conversation

@rozsival
Copy link
Copy Markdown

@rozsival rozsival commented Apr 9, 2026

Summary

Till this day, Signal does not support Markdown formatting. For that reason, it makes better sense to default its output formatter to PlainText.

Resources:

Changes

  • default output formatter for signal channel set to PlainText
  • fixed formatting with cargo fmt
  • fixed clippy warning in openfang-runtime

Testing

  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

Copilot AI review requested due to automatic review settings April 9, 2026 10:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates channel output formatting defaults so Signal uses plain text by default (since Signal does not support Markdown), and applies rustfmt/clippy-driven cleanups across the workspace.

Changes:

  • Set Signal’s default output format to PlainText in the channel bridge.
  • Apply cargo fmt-style formatting updates across several crates.
  • Address a clippy warning in SSRF-related tests (== false!...).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/openfang-runtime/src/web_search.rs Rustfmt formatting for SearxNG request URL construction.
crates/openfang-runtime/src/web_fetch.rs Test formatting + clippy cleanup in SSRF/allowlist tests.
crates/openfang-runtime/src/tool_runner.rs Rustfmt formatting around exec policy allowlist validation.
crates/openfang-runtime/src/session_repair.rs Rustfmt formatting in test predicate match arm.
crates/openfang-runtime/src/mcp.rs Rustfmt formatting for transport config builder usage.
crates/openfang-kernel/src/kernel.rs Rustfmt formatting for constants and manifest comparison expression.
crates/openfang-hands/src/registry.rs Rustfmt formatting in a unit test (single-line binding).
crates/openfang-cli/src/tui/screens/hands.rs Rustfmt formatting for HandsAction::ActivateHand construction.
crates/openfang-channels/src/discord.rs Rustfmt formatting in a JSON equality assertion test.
crates/openfang-channels/src/bridge.rs Behavior change: default output format for signal set to PlainText.
crates/openfang-api/tests/api_integration_test.rs Rustfmt formatting in an integration test assertion.
crates/openfang-api/src/routes.rs Rustfmt formatting in message filtering logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants