Fix: Improve 401 Unauthorized messages#58
Open
soe-relewise wants to merge 2 commits into
Open
Conversation
mzanoni
requested changes
May 12, 2026
Collaborator
mzanoni
left a comment
mzanoni
left a comment
There was a problem hiding this comment.
Some feedback, otherwise nice work :)
| ? $response->body | ||
| : ($response->body === null ? null : json_encode($response->body)); | ||
|
|
||
| if ($message === null || $message === false || $message === "") |
Collaborator
There was a problem hiding this comment.
If the key is wrong or missing you get this response:
Also we want to improve the error handling and falling back to "Unauthorized" is not much of an help.
Can we tell the user to verify that:
- they have provided a api key
- that the api key has permission to call the endpoint they are trying to hit
- Maybe also check that the dataset id and serverurl is correct (api key might be a valid one, but belong to a prod dataset instead of stage eg)
mzanoni
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ZxLBLURR/20167-improve-php-client-error-message-for-missing-api-key-permissions