Open
Conversation
Use the Framez for MC 1.7.10 API. Fixes ReikaKalseki/Reika_Mods_Issues#1956
Author
|
There may be other changes required for the Framez interface to compile (can't really test it obviously...), but at the very least this PR is necessary. |
Fixed naming to match the FramezAPI
Author
|
Decided to find the FramezAPI and noticed a lot more was wrong, so this would never actually successfully initialize before, it looks like everything is implemented properly now, though without a buildsystem for dragonAPI it's still a bit difficult to actually test that assertion. |
OvermindDL1
commented
Sep 14, 2018
| @Override | ||
| public boolean canHandle(World world, int x, int y, int z) { | ||
| // TODO Auto-generated method stub | ||
| return false; |
Author
There was a problem hiding this comment.
This should obviously be changed with whatever it needs to be, probably the isBlacklisted list check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the Framez for MC 1.7.10 API.
Fixes ReikaKalseki/Reika_Mods_Issues#1956