Open
Conversation
- Increased height of pause menu. Now it looks more proportionate; - Fixed an inaccuracy showing a map seed instead of selected map name while playing on selected map; - Made a capitalization of the buttons name which is more stylistically; - Moved some ticks closer to each other in "Advanced" tab; - Aligned buttons width; - Fixed an inaccuracy showing the "Load Game" button while playing on "Perma Death" mode; - Made a small spacing alignment between buttons; - Added forgotten scale factor on the line #7701.
Jabka666
commented
Aug 26, 2022
|
Seems to me like the boxes in the advanced tab were spaced apart as a way of grouping them into categories. Also, AA text looks isolated in both the before and after... maybe it should be grouped like normal and only be moved down while the framelimit slider is visible? |
Contributor
Author
Well yeah, would be better to move AAText upper. It looks isolated because of Framelimit slidebar. Don't forget that slidebars don't have a rescale, so on lower resolutions it can be overlapped |
- The ``AAText`` checkbox has been moved closer to the others; - Added ``MenuGray`` texture for locked buttons, ticks, inputboxes and etc.; - Added ``ButtonSFX2`` sound while clicling on locked button or tick; - Added new parameter in ``DrawButton`` function called "locked" for easier adding locked buttons; - Moved down arrows in save and custom map menus; - Added ability to delete custom map; - Made a capitalization of the buttons name which is more stylistically (in Main Menu); - Reduce menu height when the ``Framelimit`` or ``Usertrack`` options are hidden; - Reduced the number of saves per page from 6 to 5; - Fixed being able to press the ``BACK`` button when deleting a save; - Fixed arrows shifting one pixel in the save and custom map menus; - Slightly improved input boxes design (used ``DrawFrame`` instead of ``Rect``, so they stylistically similar to buttons and ticks).
Contributor
Author
- A "Back" wasn't all caps - A "Page" wasn't all caps - Two "Screen gamma"s didn't have a colon - "Open/Close Inventory" was too long
- Center pause menu title text to match ending screen title text - Move user track mode text to right of tick box like it is in main menu - Declare TempStr as a local in menu drawing functions (and rename it to the more common strtemp) - Center save file and custom map info text - Fix SlideBar "LOW" and "HIGH" text being considerably lower than the bar
- Horizontally center "YES" and "NO" deletion confirmation buttons - Better align "ACHIEVEMENTS" and "MAIN MENU" buttons on ending screen - Make achievement menu page buttons square and add disabled buttons to match load game/load map page buttons
It looks perfect at native 1024p now, but due to rounding errors with the menu scaling system, some menu elements still get misaligned by 1px at higher resolutions... I think ideally all coordinates should be floats, and nothing should be multiplied by MenuScale until the moment buttons/frames are drawn. Removing all instances of *MenuScale would be a hassle though...
Improvements to better pause menu
- Added ``Enable launcher`` and ``Play startup videos`` ticks; - Automatically turn off antialiasing option while playing in non-fullscreen mode. Also make the tick locked; - Don't used ``True/False`` statements in ``options.ini`` anymore; - Hide ``Open console on error`` option when the ``Enable console`` is turned off. Note: Use ``PlayStartup`` variable in ``PlayStartupVideos`` function when the PR ``Better PlayStartupVideos function Regalis11#205`` will be merged.
Contributor
Author
- Used ``ResetInput`` to prevent clicking on the locked button while quitting the game; - Added ``HidePointer`` while loading a game.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.















Advancedtab;Load Gamebutton while playing onPerma Deathmode;Initial commit without buttons name capitalization: 17203591f83dc92267bbcccf570e06c9fc579ca2
Before:
After: