Remove .prefab file loading functionality and log level broadcasting#3
Merged
Conversation
This commit completely removes the legacy .prefab file loading system and associated log level change broadcasting functionality to simplify the SDK: **Removed .prefab file loading:** - Removed loadClasspathConfig() and loadOverrideConfig() methods from ConfigLoader - Removed prefab-envs configuration system from Options class - Updated tests to work without file-based configuration loading - Removed tests that depended on .prefab files in override directories **Removed log level broadcasting:** - Deleted LogLevelChangeListener and LogLevelChangeEvent classes - Deleted AbstractLoggingListener and JavaUtilLoggingConfigListener classes - Removed log level change listener support from Options and ConfigClientImpl - Simplified UpdatingConfigResolver to only handle config changes - Removed associated test files and updated remaining tests **Breaking changes:** - Options.setPrefabEnvs(), getPrefabEnvs(), getAllPrefabEnvs() methods removed - Options.addLogLevelChangeListener(), getLogLevelChangeListeners() methods removed - LogLevelChangeListener, LogLevelChangeEvent, AbstractLoggingListener classes removed - .prefab config files are no longer loaded from classpath or override directories The SDK now relies solely on API-based configuration and JSON datafile loading. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes
Removed Methods
Options.setPrefabEnvs(),getPrefabEnvs(),getAllPrefabEnvs()Options.addLogLevelChangeListener(),getLogLevelChangeListeners()Removed Classes
LogLevelChangeListenerLogLevelChangeEventAbstractLoggingListenerJavaUtilLoggingConfigListenerBehavior Changes
.prefab.*.config.yamlfiles are no longer loaded from classpath or override directoriesTest Plan
Files Changed
This simplifies the SDK significantly by removing two complex legacy systems that were not commonly used.
🤖 Generated with Claude Code