Skip to content

Header tweaks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 1 commit into from
Sep 18, 2025
Merged

Header tweaks #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sdk/src/main/java/com/reforge/sdk/internal/HttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public class HttpClient {

private static final Logger LOG = LoggerFactory.getLogger(HttpClient.class);

public static final String CLIENT_HEADER_KEY = "client";
private static final String VERSION_HEADER = "X-Reforge-SDK-Version";

public static final String CLIENT_HEADER_VALUE = String.format(
Expand All @@ -50,7 +49,7 @@ public class HttpClient {

private static final String PROTO_MEDIA_TYPE = "application/x-protobuf";
private static final String EVENT_STREAM_MEDIA_TYPE = "text/event-stream";
private static final String START_AT_HEADER = "x-prefab-start-at-id";
private static final String START_AT_HEADER = "Last-Event-ID";

private final Options options;
private final java.net.http.HttpClient httpClient;
Expand Down Expand Up @@ -343,7 +342,6 @@ private HttpResponse<Supplier<Prefab.Configs>> createCachedHitResponse(
private HttpRequest.Builder getClientBuilderWithStandardHeaders() {
return HttpRequest
.newBuilder()
.header(CLIENT_HEADER_KEY, CLIENT_HEADER_VALUE)
.header(VERSION_HEADER, NEW_CLIENT_HEADER_VALUE)
.header(
"Authorization",
Expand Down