refactor: separate analysis #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overview
Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
|
tristan-f-r
added
analysis
ntalluri
reviewed
Feb 5, 2026
| ensemble: | ||
| include: true | ||
| aggregate_per_algorithm: true | ||
| evaluation: |
Collaborator
There was a problem hiding this comment.
I want the ML code and evaluation to be separate analysis options in the config even though they are internally coupled.
Collaborator
Author
There was a problem hiding this comment.
To clarify, it should be analysis.evaluation and not analysis.ensemble.evaluation?
ntalluri
reviewed
Feb 5, 2026
ntalluri
reviewed
Feb 5, 2026
Collaborator
There was a problem hiding this comment.
Look at comments for config/config.yaml about how to separate evaluation and ML.
ntalluri
reviewed
Feb 5, 2026
Collaborator
There was a problem hiding this comment.
Look at comments for config/config.yaml about how to separate evaluation and ML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits analysis into a more detailed configuration, allowing parts of the Snakemake workflow to depend only on parts of the config. This has the con of making it more annoying to blanket-enable all analysis. Closes #331.