Fixing issue #160#164
Open
emesika wants to merge 1 commit into
Open
Conversation
code :
if parse_type[0].startswith("ns"):
cls._cls_suds_map[local_name]["cls"] = globals()[parse_type[1]]
cls._cls_suds_map[local_name]["enum_id"] = getattr(cft, "enum_id", None)
cls._cls_suds_map[local_name]["is_custom"] = True
cls._cls_suds_map[local_name]["control"] = cls._wi_type
Error :
File "/home/emesika/.local/lib/python3.9/site-packages/pylero/work_item.py", line 1464, in get_custom_fields
print(f"Global = {globals()[parse_type[1]]}")
KeyError: 'duration'
Happens on :
local name = sprint_estimate
parse_type = duration
should skip non existing parse_type[1] in globals() :
if parse_type[0].startswith("ns"):
if parse_type[1] not in globals():
continue
cls._cls_suds_map[local_name]["cls"] = globals()[parse_type[1]]
cls._cls_suds_map[local_name]["enum_id"] = getattr(cft, "enum_id", None)
cls._cls_suds_map[local_name]["is_custom"] = True
cls._cls_suds_map[local_name]["control"] = cls._wi_type
Signed-off-by: Eli Mesika <emesika@redhat.com>
Collaborator
|
Unfortunately the fix seems like a workaround, maybe the original assumption that all |
Collaborator
|
to the projects that I've access I don't see a custom field with duration as ns object, if possible could you pls ping me internally and reach a conclusion. thanks. |
Collaborator
|
@emesika any info about what Leela asked in the comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code :
if parse_type[0].startswith("ns"):
cls._cls_suds_map[local_name]["cls"] = globals()[parse_type[1]] cls._cls_suds_map[local_name]["enum_id"] = getattr(cft, "enum_id", None) cls._cls_suds_map[local_name]["is_custom"] = True
cls._cls_suds_map[local_name]["control"] = cls._wi_type
Error :
File "/home/emesika/.local/lib/python3.9/site-packages/pylero/work_item.py", line 1464, in get_custom_fields print(f"Global = {globals()[parse_type[1]]}")
KeyError: 'duration'
Happens on :
local name = sprint_estimate
parse_type = duration
should skip non existing parse_type[1] in globals() :
if parse_type[0].startswith("ns"):
if parse_type[1] not in globals():
continue
cls._cls_suds_map[local_name]["cls"] = globals()[parse_type[1]] cls._cls_suds_map[local_name]["enum_id"] = getattr(cft, "enum_id", None) cls._cls_suds_map[local_name]["is_custom"] = True
cls._cls_suds_map[local_name]["control"] = cls._wi_type