[4.20] Add OCS to AWS global config#5482
Conversation
Add CEPH_RBD_VIRTUALIZATION entry, move default flag from TRIDENT_CSI_FSX to IO2_CSI to align with main. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Jenia Peimer <jpeimer@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
/verified |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| Images.Windows.DEFAULT_DV_SIZE = "75Gi" | ||
|
|
||
| storage_class_matrix = [ | ||
| { |
There was a problem hiding this comment.
Test Execution Plan
- Run smoke tests: False —
tests/global_config_aws.pyis apytest_testconfigdata file loaded only when tests are executed with the AWS-specific--tc-fileoption; it is not imported bytests/conftest.pyor any autouse fixture by default, so no smoke-marked test is exercised through the standard collection path. - Run gating tests: False — No gating-marked test imports this file or the changed symbols (
CEPH_RBD_VIRTUALIZATION,IO2_CSI,TRIDENT_CSI_FSX) directly; impact is limited to the AWS storage-class matrix used only when this config is explicitly selected. - Affected tests to run (only when executed against the AWS config, i.e. with
--tc-file=tests/global_config_aws.pyor equivalent AWS job config):-m storage(any test consuming thestorage_class_matrixfixture, e.g.tests/storage/test_wffc.py,tests/storage/test_hotplug.py,tests/storage/cdi_clone/,tests/storage/cdi_import/,tests/storage/cdi_upload/,tests/storage/snapshots/) — newCEPH_RBD_VIRTUALIZATIONentry adds a new matrix parametrization, and movingdefault: TruefromTRIDENT_CSI_FSXtoIO2_CSIchanges which storage class is used for non-matrixed/default-storage-class tests.- Any test using
storage_class_a/storage_class_b(both now resolve toIO2_CSI, unchanged) — low risk, verify no regression.
Real tests (cluster required, AWS)
Happy path (regression, default storage class now IO2_CSI):
pytest tests/storage/test_wffc.py --tc-file=tests/global_config_aws.py --collect-only
Expected: collection succeeds, IO2_CSI used as default storage class, TRIDENT_CSI_FSX matrix entry still present without default flag.
New entry sanity check (CEPH_RBD_VIRTUALIZATION):
pytest tests/storage/test_hotplug.py --tc-file=tests/global_config_aws.py -k ceph_rbd_virtualization
Expected: new storage-class matrix entry is picked up and tests run/skip appropriately based on cluster storage-class availability.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr view 5482 --repo RedHatQE/openshift-virtualization-tests --json files,title,body -q '.files[].path'
echo "---DIFF---"
gh pr diff 5482 --repo RedHatQE/openshift-virtualization-testsLength of output: 1388 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== storage_class_matrix usage =="
rg -l 'storage_class_matrix' tests/ | head -30
echo "== StorageClassNames.CEPH_RBD_VIRTUALIZATION =="
rg -n 'CEPH_RBD_VIRTUALIZATION' -r '' --hidden -g '!*.pyc' . | head -30
echo "== IO2_CSI / TRIDENT_CSI_FSX =="
rg -n 'IO2_CSI|TRIDENT_CSI_FSX' . | head -30
echo "== storage_class_matrix fixture definition =="
rg -n 'def storage_class_matrix' -A 15 tests/ | head -60
echo "== smoke marker in storage tests =="
rg -l '`@pytest.mark.smoke`' tests/storage/ | head -30
echo "== gating marker in storage tests =="
rg -l '`@pytest.mark.gating`' tests/storage/ | head -30Length of output: 4765 🏁 Script executed: #!/bin/bash
set -euo pipefail
cat -n tests/global_config_aws.py | sed -n '1,60p'Length of output: 2342 🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr view 5482 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q '.headRefOid'Length of output: 307 🏁 Script executed: #!/bin/bash
set -euo pipefail
REPO="RedHatQE/openshift-virtualization-tests"
PR=5482
SHA="e1000a01aa27f9573d4e151b194b16ad41aba9b2"
BODY=$(cat <<'EOF'
**Test Execution Plan**
- **Run smoke tests: False** — `tests/global_config_aws.py` is a `pytest_testconfig` data file loaded only when tests are executed with the AWS-specific `--tc-file` option; it is not imported by `tests/conftest.py` or any autouse fixture by default, so no smoke-marked test is exercised through the standard collection path.
- **Run gating tests: False** — No gating-marked test imports this file or the changed symbols (`CEPH_RBD_VIRTUALIZATION`, `IO2_CSI`, `TRIDENT_CSI_FSX`) directly; impact is limited to the AWS storage-class matrix used only when this config is explicitly selected.
- **Affected tests to run** (only when executed against the AWS config, i.e. with `--tc-file=tests/global_config_aws.py` or equivalent AWS job config):
- `-m storage` (any test consuming the `storage_class_matrix` fixture, e.g. `tests/storage/test_wffc.py`, `tests/storage/test_hotplug.py`, `tests/storage/cdi_clone/`, `tests/storage/cdi_import/`, `tests/storage/cdi_upload/`, `tests/storage/snapshots/`) — new `CEPH_RBD_VIRTUALIZATION` entry adds a new matrix parametrization, and moving `default: True` from `TRIDENT_CSI_FSX` to `IO2_CSI` changes which storage class is used for non-matrixed/default-storage-class tests.
- Any test using `storage_class_a` / `storage_class_b` (both now resolve to `IO2_CSI`, unchanged) — low risk, verify no regression.
**Real tests (cluster required, AWS)**
Happy path (regression, default storage class now `IO2_CSI`):
`pytest tests/storage/test_wffc.py --tc-file=tests/global_config_aws.py --collect-only`
Expected: collection succeeds, `IO2_CSI` used as default storage class, `TRIDENT_CSI_FSX` matrix entry still present without `default` flag.
New entry sanity check (`CEPH_RBD_VIRTUALIZATION`):
`pytest tests/storage/test_hotplug.py --tc-file=tests/global_config_aws.py -k ceph_rbd_virtualization`
Expected: new storage-class matrix entry is picked up and tests run/skip appropriately based on cluster storage-class availability.
EOF
)
gh api \
--method POST \
-H "Accept: application/vnd.github+json" \
"/repos/${REPO}/pulls/${PR}/comments" \
-f body="$BODY" \
-f commit_id="$SHA" \
-f path="tests/global_config_aws.py" \
-F line=14 \
-f side="RIGHT"Length of output: 7118 Inline test execution plan comment posted on |
5 participants
What this PR does / why we need it:
Add
CEPH_RBD_VIRTUALIZATIONentry, move default flag fromTRIDENT_CSI_FSXtoIO2_CSIto align withmain.Assisted-by: Claude noreply@anthropic.com
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: