Remove duplicated T2 must-gather tests covered by upstream T1#5476
Remove duplicated T2 must-gather tests covered by upstream T1#5476OhadRevah wants to merge 1 commit into
Conversation
Remove T2 tests that are already validated by stricter upstream T1 tests in kubevirt/must-gather (using reflect.DeepEqual on full spec): - CNV-3042 (NetworkAddonsConfig) - CNV-3373 (CDIConfig) - CNV-3043 (VirtualMachine) Remove CNV-2983 (kubemacpool-leader pod) as it's covered by CNV-8880 which selects all kubemacpool pods including the leader. Consolidate CNV-2939 (ImageStreamTag count + content validation) into CNV-9236 in test_must_gather_images.py. Add pytest.mark.dependency between test_no_new_cnv_crds (CNV-8508) and test_crd_resources (CNV-2724) to skip CRD validation when unknown CRDs are detected. Upstream T1 proof (validate_must_gather_test.go): - L107: CDIConfig cluster-scoped resource validation - L109: NetworkAddonsConfig cluster-scoped resource validation - L133-135: reflect.DeepEqual on full spec for both - L239-257: VirtualMachine DescribeTable validation - L267-283: validateVmFile with reflect.DeepEqual on full VM spec https://github.com/kubevirt/must-gather/blob/92d6483f/tests/validate_must_gather_test.go assisted by: claude code claude-opus-4-6 Signed-off-by: Ohad <orevah@redhat.com>
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
What this PR does / why we need it:
Remove T2 tests that are already validated by stricter upstream T1 tests in kubevirt/must-gather (using reflect.DeepEqual on full spec):
Remove CNV-2983 (kubemacpool-leader pod) as it's covered by CNV-8880 which selects all kubemacpool pods including the leader.
Consolidate CNV-2939 (ImageStreamTag count + content validation) into CNV-9236 in test_must_gather_images.py.
Add pytest.mark.dependency between test_no_new_cnv_crds (CNV-8508) and test_crd_resources (CNV-2724) to skip CRD validation when unknown CRDs are detected.
Upstream T1 proof (validate_must_gather_test.go):
assisted by: claude code claude-opus-4-6
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-35404