Skip to content

Remove duplicated T2 must-gather tests covered by upstream T1#5476

Open
OhadRevah wants to merge 1 commit into
RedHatQE:mainfrom
OhadRevah:remove-duplicated-t2-must-gather-tests
Open

Remove duplicated T2 must-gather tests covered by upstream T1#5476
OhadRevah wants to merge 1 commit into
RedHatQE:mainfrom
OhadRevah:remove-duplicated-t2-must-gather-tests

Conversation

@OhadRevah

Copy link
Copy Markdown
Contributor
What this PR does / why we need it:

Remove T2 tests that are already validated by stricter upstream T1 tests in kubevirt/must-gather (using reflect.DeepEqual on full spec):

  • CNV-3042 (NetworkAddonsConfig)
  • CNV-3373 (CDIConfig)
  • CNV-3043 (VirtualMachine)

Remove CNV-2983 (kubemacpool-leader pod) as it's covered by CNV-8880 which selects all kubemacpool pods including the leader.

Consolidate CNV-2939 (ImageStreamTag count + content validation) into CNV-9236 in test_must_gather_images.py.

Add pytest.mark.dependency between test_no_new_cnv_crds (CNV-8508) and test_crd_resources (CNV-2724) to skip CRD validation when unknown CRDs are detected.

Upstream T1 proof (validate_must_gather_test.go):

assisted by: claude code claude-opus-4-6

Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

https://redhat.atlassian.net/browse/CNV-35404

Remove T2 tests that are already validated by stricter upstream T1 tests
in kubevirt/must-gather (using reflect.DeepEqual on full spec):
- CNV-3042 (NetworkAddonsConfig)
- CNV-3373 (CDIConfig)
- CNV-3043 (VirtualMachine)

Remove CNV-2983 (kubemacpool-leader pod) as it's covered by CNV-8880
which selects all kubemacpool pods including the leader.

Consolidate CNV-2939 (ImageStreamTag count + content validation) into
CNV-9236 in test_must_gather_images.py.

Add pytest.mark.dependency between test_no_new_cnv_crds (CNV-8508) and
test_crd_resources (CNV-2724) to skip CRD validation when unknown CRDs
are detected.

Upstream T1 proof (validate_must_gather_test.go):
- L107: CDIConfig cluster-scoped resource validation
- L109: NetworkAddonsConfig cluster-scoped resource validation
- L133-135: reflect.DeepEqual on full spec for both
- L239-257: VirtualMachine DescribeTable validation
- L267-283: validateVmFile with reflect.DeepEqual on full VM spec
https://github.com/kubevirt/must-gather/blob/92d6483f/tests/validate_must_gather_test.go

assisted by: claude code claude-opus-4-6

Signed-off-by: Ohad <orevah@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@OhadRevah, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5c40606d-6818-4c87-8d9d-9b690680209f

📥 Commits

Reviewing files that changed from the base of the PR and between 93d8ab2 and ff7878e.

📒 Files selected for processing (3)
  • tests/install_upgrade_operators/must_gather/test_must_gather.py
  • tests/install_upgrade_operators/must_gather/test_must_gather_images.py
  • tests/install_upgrade_operators/must_gather/test_must_gather_vms.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-virtualization-qe-bot-5

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Custom Commands

  • /test-plan - Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
  • /rerun-smoke - Adds `retest-smoke` label on the PR to trigger smoke tests exectuion

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • OhadRevah
  • RoniKishner
  • albarker-rh
  • dshchedr
  • hmeir
  • rlobillo
  • rnetser
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants