WIP: net, tests, hot-plug: Force CNV-77961 W/A paths for verification#5467
WIP: net, tests, hot-plug: Force CNV-77961 W/A paths for verification#5467Anatw wants to merge 3 commits into
Conversation
hot_plug_interface() already returns the full interface status including interfaceName. Pass it through to set_secondary_static_ip_address() instead of re-querying VMI status for the same value. Signed-off-by: Anat Wax <awax@redhat.com> Assisted-by: Claude <noreply@anthropic.com>
CNV-77961 causes guest-agent to stop reporting newly hot-plugged interfaces, failing tests that depend on interface data from VMI status. Work around the bug so tests continue to run until the fix is released. Signed-off-by: Anat Wax <awax@redhat.com> Assisted-by: Claude <noreply@anthropic.com>
For testing purposes only. Kill guest-agent before hot-plug and omit guest_device_name to guarantee all three W/A fallback paths are exercised. Not for review or merge. Needed for PR RedHatQE#5466 Signed-off-by: Anat Wax <awax@redhat.com> Assisted-by: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-and-push-container |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
/wip |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5467 published |
What this PR does / why we need it:
Force all three CNV-77961 W/A fallback paths to verify them end-to-end. This is a verification-only PR, not for review or merge.
Guest-agent is killed (
systemctl mask --now qemu-guest-agent) before hot-plug, andguest_device_nameis omitted fromset_secondary_static_ip_addresscalls, to guarantee all three console-based fallback paths are exercised:hot_plug_interface()→_iface_console_fallback(agent dead, VMI status times out)set_secondary_static_ip_address()→_read_guest_ipv4(agent dead, IP not reported)get_guest_vm_interface_name_by_vmi_interface_name()→_iface_console_fallback(guest_device_nameomitted)Which issue(s) this PR fixes:
Special notes for reviewer:
Verification-only — not for merge. Contains temporary agent kill/restore code in test fixtures. Needed for the verification of #5466
jira-ticket:
https://issues.redhat.com/browse/CNV-77961